590 B
590 B
Code Review Best Practices
Default review order
- Understand intent and scope.
- Check architecture and correctness.
- Check tests and failure handling.
- Check security and performance risks.
- Leave clear, prioritized comments.
Comment severity
blocking- correctness, security, data loss, major maintainability issueimportant- should be fixed before merge if practicalnit- polish only
Good reviewer habits
- summarize first,
- separate required changes from suggestions,
- quote the code path or failure mode,
- praise good decisions when they matter.